fix: Runtime.markPersistent is unsafe
#6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kha
force-pushed
the
push-yoomxlrqlouo
branch
from
b5c199c to
c38b2b4
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 25, 2024
|
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
leodemoura
reviewed
Nov 25, 2024
| @@ -630,16 +625,24 @@ where | |||
| -- definitely resolve eventually | |||
| snap.new.resolve <| .ofTyped { diagnostics := .empty : SnapshotLeaf } | |||
|
|
|||
| let mut infoTree := cmdState.infoState.trees[0]! | |||
| let mut infoTree : InfoTree := cmdState.infoState.trees[0]! | |||
There was a problem hiding this comment.
Why do need to provide the type annotation here? Is the goal to improve readability or workaround an elaboration issue?
leodemoura
approved these changes
Nov 25, 2024
|
!bench |
|
Here are the benchmark results for commit c38b2b4. Benchmark Metric Change
=========================================
+ big_do task-clock -9.0% (-12.5 σ)
+ big_do wall-clock -9.0% (-12.6 σ)
+ stdlib wall-clock -1.1% (-12.0 σ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents under which conditions
Runtime.markPersistentis unsafe and adjusts the elaborator accordingly